Differences

This shows you the differences between two versions of the page.

Link to this comparison view

Both sides previous revision Previous revision
Next revision
Previous revision
coding-standards [2017/09/01 20:43]
51.6.19.28 [Follow C== practices]
coding-standards [2020/11/05 21:36]
wolfmanjm [Do not use blocking wait loops]
Line 88: Line 88:
 branches should be called feature/feature-name or fix/fix-name, and only contain changed relevant to that feature or fix. branches should be called feature/feature-name or fix/fix-name, and only contain changed relevant to that feature or fix.
 If other changes need to be made that are not directly related to this change but this change relies on them then it should be noted in the pull request that it depends on pull request #xxxx If other changes need to be made that are not directly related to this change but this change relies on them then it should be noted in the pull request that it depends on pull request #xxxx
 +
 +=== Do not use blocking wait loops
 +There must not be any blocking wait loops in the code, there is no RTOS here so a blocking wait loop stops everything from running, and if long enough will trigger the watchdog timer. In the case of needing to wait for several milliseconds you can use the ''safe_delay_ms'' or ''safe_delay_us'' function call, which will call on_idle() to keep things going. However note this is not an accurate delay. For accurate timing an interupt timer must be used.
 +