Differences

This shows you the differences between two versions of the page.

Link to this comparison view

Both sides previous revision Previous revision
Next revision
Previous revision
contribution-guidlines [2017/01/25 16:09]
arthur
contribution-guidlines [2018/09/03 12:50] (current)
rom1detroyes [Contribution Guidelines] Misspell
Line 5: Line 5:
 In order for a Pull request to be accepted it must meet certain standards and guidelines. In order for a Pull request to be accepted it must meet certain standards and guidelines.
  
-In addition to following the [[[[Coding-Standards]]]] it is suggested the following be adopted.+In addition to following the [[Coding-Standards]] it is suggested the following be adopted.
  
 # There must be a detailed description of the change, why it was added and what the use case is, and a link to the documentation to use it in the wiki if applicable. # There must be a detailed description of the change, why it was added and what the use case is, and a link to the documentation to use it in the wiki if applicable.
Line 13: Line 13:
 # Do not make changes that are specific to your setup. Smoothie needs to work in many different environments. # Do not make changes that are specific to your setup. Smoothie needs to work in many different environments.
 # Do not make changes that customize messages specific to your company or implementation. You are welcome to do this in your own fork and binary, it is not ok to try to merge that into the upstream repository. # Do not make changes that customize messages specific to your company or implementation. You are welcome to do this in your own fork and binary, it is not ok to try to merge that into the upstream repository.
-# Test your changes ​is as many different configurations as you can, eg different arm solutions. In the Pull request state what tests have been done and what tests need to be done.+# Test your changes ​in as many different configurations as you can, eg different arm solutions. In the Pull request state what tests have been done and what tests need to be done.
 # Do not commit changes to the FirmwareBin directory or any binary files in the repository. # Do not commit changes to the FirmwareBin directory or any binary files in the repository.
 # Do not reformat the Config Samples to suit your style. # Do not reformat the Config Samples to suit your style.